Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Content-MD5 when generating presigned URL for uploading object (#1161) #1252

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Specify Content-MD5 when generating presigned URL for uploading object (#1161) #1252

wants to merge 6 commits into from

Conversation

hardikSinghBehl
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Allows contentMD5 value to be specified in the S3 ObjectMetadata.

💡 Motivation and Context

Implementation for issue #1161

💚 How did you test it?

The functionality has been tested via an integration test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@hardikSinghBehl hardikSinghBehl marked this pull request as draft October 8, 2024 10:45
@hardikSinghBehl hardikSinghBehl marked this pull request as ready for review October 8, 2024 10:45
@hardikSinghBehl hardikSinghBehl mentioned this pull request Oct 8, 2024
Open
@maciejwalkowiak maciejwalkowiak added component: s3 S3 integration related issue type: enhancement Smaller enhancement in existing integration labels Nov 11, 2024
@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 M2 milestone Nov 11, 2024
@github-actions github-actions bot removed the component: s3 S3 integration related issue label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak maciejwalkowiak approved these changes

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
type: enhancement Smaller enhancement in existing integration
Projects
None yet
Milestone
3.3.0 M2
Development

Successfully merging this pull request may close these issues.
2 participants
@hardikSinghBehl @maciejwalkowiak