Populate content/index.json manifest list #784
Conversation
| // FIXME: This runs far too soon. Writing index.json for the soci content store should happen after each change to the store and/or when the snapshotter shuts down. | ||
| defer done(ctx) |
There was a problem hiding this comment.
All the other cases are single CLI commands which perform some operation then clean up after themselves. Here we are creating the filesystem for the snapshotter which will be used for an indefinite period. This done should happen when the filesystem is closed, probably when the snapshotter is exiting. An equivalent operation (which wouldn't really be "done") may also be needed after each new content creation. Either or both of these options would require putting the function into the filesystem struct (or somewhere else persistent) to be called later.
I am seeking input on the desirable path forward here.
There was a problem hiding this comment.
This operation could be moved into Push but would then happen far more often than is reasonable for sequential operations.
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
force-pushed
the
647_enumerate_manifests_in_content_index_json
branch
from
9b3e9f6
to
8413676
Compare
Issue #, if available:
Closes #647
Description of changes:
TagnewlyPushed content in the soci content store, then doSaveIndexafter performing content store operations to enumerate tagged content incontent/index.json'smanifestsarray.Testing performed:
Existing unit and integration tests.
Manual creation of an index and check for a populated manifests array.
Needs new tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.