Implement thread::park and Thread::unpark
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorajeev
approved these changes
Aug 22, 2022
| let condvar = Arc::clone(&condvar); | ||
| thread::spawn(move || { | ||
| let mut guard = lock.lock().unwrap(); | ||
| while !*guard { |
There was a problem hiding this comment.
Think a better version of this test would be to replace the while with an if and then add an assert!(*guard) afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missing, as pointed out in #75. They're not too hard to implement---we just add an explicit
park_stateto each task.There's a subtlety here in that
parkwon't work well with futures due to our one-future-per-thread model, but the behavior ofparkwithin a future is probably unreliable on any realistic async runtime anyway. This is one of a class of behaviors around async that maybe we should have some way of warning about.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.