[GSProcessing] Supplement for GConstruct Config Check for GSProcessing #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvasilo
requested changes
Jul 29, 2024
graphstorm-processing/graphstorm_processing/config/config_conversion/gconstruct_converter.py
Outdated
Show resolved
Hide resolved
graphstorm-processing/graphstorm_processing/config/config_conversion/gconstruct_converter.py
Outdated
Show resolved
Hide resolved
graphstorm-processing/graphstorm_processing/config/config_conversion/gconstruct_converter.py
Outdated
Show resolved
Hide resolved
graphstorm-processing/graphstorm_processing/config/config_conversion/gconstruct_converter.py
Outdated
Show resolved
Hide resolved
jalencato
force-pushed
the
gconstruct_gsprocessing_config_validation
branch
from
0e817a3 to
b217b4b
Compare
|
Code looks good, could we add 1-2 tests that ensure the assertions are raised for invalid input? Use https://docs.pytest.org/en/7.1.x/how-to/assert.html#assertions-about-expected-exceptions |
thvasilo
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#747
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.