-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSProcessing] Add option to truncate vectors with no-op transformation. #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comment
.../graphstorm_processing/data_transformations/dist_transformations/dist_noop_transformation.py
Outdated
Show resolved
Hide resolved
docs/source/graph-construction/gs-processing/input-configuration.rst
Outdated
Show resolved
Hide resolved
.../graphstorm_processing/data_transformations/dist_transformations/dist_noop_transformation.py
Show resolved
Hide resolved
Added GCosntsruct support @jalencato let me know if there's something missing for config parsing. I couldn't find any gconstruct docs in the current doc structure, they'll need to be added later or we can rebase this PR once those are added back. |
It should be just about the feature transformation configuration for GConstruct: https://graphstorm.readthedocs.io/en/latest/configuration/configuration-gconstruction.html#configurations-gconstruction And for the files on Github: https://github.com/awslabs/graphstorm/blob/main/docs/source/configuration/configuration-gconstruction.rst. Changing the content here will not affect the doc refactor as we always to the entire doc when doing the refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes:
truncate_dim
. When a user provides this parameter, we will try to truncate the input vectors to the dimension specified. This allows users to easily make use of input Matryoshka embeddings.Testing
Unit tests passing, unit and integration test added for the new transformation option.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.