Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Add option to truncate vectors with no-op transformation. #922

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

thvasilo
Copy link
Contributor

@thvasilo thvasilo commented Jul 13, 2024

Issue #, if available:

Description of changes:

  • We add a keyword argument to the GSProcessing no-op transformation, named truncate_dim. When a user provides this parameter, we will try to truncate the input vectors to the dimension specified. This allows users to easily make use of input Matryoshka embeddings.
  • (Revision) Added the same transformation for GConstruct.

Testing

Unit tests passing, unit and integration test added for the new transformation option.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added ready able to trigger the CI gsprocessing For issues and PRs related the the GSProcessing library 0.3.1 labels Jul 13, 2024
@thvasilo thvasilo added this to the 0.3.1 milestone Jul 13, 2024
@thvasilo thvasilo requested a review from jalencato July 13, 2024 00:04
@thvasilo thvasilo self-assigned this Jul 13, 2024
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comment

@thvasilo
Copy link
Contributor Author

Added GCosntsruct support @jalencato let me know if there's something missing for config parsing. I couldn't find any gconstruct docs in the current doc structure, they'll need to be added later or we can rebase this PR once those are added back.

@jalencato
Copy link
Collaborator

jalencato commented Jul 15, 2024

Added GCosntsruct support @jalencato let me know if there's something missing for config parsing. I couldn't find any gconstruct docs in the current doc structure, they'll need to be added later or we can rebase this PR once those are added back.

It should be just about the feature transformation configuration for GConstruct: https://graphstorm.readthedocs.io/en/latest/configuration/configuration-gconstruction.html#configurations-gconstruction

And for the files on Github: https://github.com/awslabs/graphstorm/blob/main/docs/source/configuration/configuration-gconstruction.rst.

Changing the content here will not affect the doc refactor as we always to the entire doc when doing the refactor.

Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo merged commit e7208d9 into awslabs:main Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3.1 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants