Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix node class full graph infer #850

Merged
merged 2 commits into from
May 19, 2024

Conversation

classicsong
Copy link
Contributor

@classicsong classicsong commented May 17, 2024

Issue #, if available:

Description of changes:
Originally, node_mini_batch_predict expect its argument loader is a node dataloader with 0 GNN layers (fanout=[]). However, this can not been guaranteed.

Change the implementation to make it work with node dataloader with/without GNN layers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong added bug Something isn't working 0.3 ready able to trigger the CI labels May 17, 2024
Copy link
Contributor

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggest to add a comment line to explain this corner case.

python/graphstorm/model/node_gnn.py Outdated Show resolved Hide resolved
@classicsong classicsong removed the ready able to trigger the CI label May 18, 2024
@classicsong classicsong merged commit 1ba9928 into awslabs:main May 19, 2024
6 checks passed
@classicsong classicsong deleted the fix-node-fullgraph-infer branch May 19, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants