[WholeGraph] Setup CI for WholeGraph support #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#734) *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
zheng-da
reviewed
Feb 15, 2024
*Issue #, if available:* There is no end2end test for wholegraph sparse embedding. *Description of changes:* Add test scripts. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: Xiang Song <[email protected]>
chang-l
reviewed
Feb 16, 2024
There was a problem hiding this comment.
@classicsong Looks like you need to update the ci branch to have this commit 113a388 included in this PR.
Sorry, just realized it already merged into main... Stamping
chang-l
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR fixes some bugs in WholeGraphSupport: #734 and add end2end test: #732
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.