Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Allow custom out_dtype in feature transformation #739

Merged
merged 28 commits into from
Mar 23, 2024

Conversation

jalencato
Copy link
Collaborator

@jalencato jalencato commented Feb 15, 2024

Issue #, if available:

Description of changes:

  • Add out_dtype support for no-op, numerical, and multi-numerical transformation for float32 for floatType and float64 for doubleType.

  • Allow transformation between gconstruct and gsprocessing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jalencato jalencato added 0.3 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI labels Feb 16, 2024
@jalencato jalencato self-assigned this Feb 21, 2024
@jalencato jalencato marked this pull request as ready for review March 18, 2024 19:31
Copy link
Contributor

@thvasilo thvasilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comments.

@jalencato jalencato changed the title [GSProcessing] Allow custom output_dtype in feature transformation [GSProcessing] Allow custom out_dtype in feature transformation Mar 22, 2024
@jalencato jalencato merged commit ee4c49c into awslabs:main Mar 23, 2024
3 checks passed
@jalencato jalencato deleted the gsp_output_dtype branch September 4, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants