-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSProcessing] Allow custom out_dtype in feature transformation #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalencato
added
0.3
gsprocessing
For issues and PRs related the the GSProcessing library
ready
able to trigger the CI
labels
Feb 16, 2024
thvasilo
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minor comments.
graphstorm-processing/graphstorm_processing/config/numerical_configs.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Theodore Vasiloudis <[email protected]>
jalencato
changed the title
[GSProcessing] Allow custom output_dtype in feature transformation
[GSProcessing] Allow custom out_dtype in feature transformation
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.3
gsprocessing
For issues and PRs related the the GSProcessing library
ready
able to trigger the CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add out_dtype support for no-op, numerical, and multi-numerical transformation for float32 for floatType and float64 for doubleType.
Allow transformation between gconstruct and gsprocessing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.