[WholeGraph] Add support of using WholeGraph to store/load cache_lm_emb #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zheng-da
reviewed
Feb 14, 2024
thvasilo
added
documentation
|
everything else looks good to me. |
classicsong
reviewed
Feb 16, 2024
chang-l
commented
Feb 17, 2024
classicsong
reviewed
Feb 19, 2024
classicsong
reviewed
Feb 20, 2024
classicsong
pushed a commit
that referenced
this pull request
Feb 21, 2024
This is to address the concern brought up here: #737 (comment). It changes the flag name `use-wholegraph-sparse-emb` --> `use-wholegraph-embed`, in consistent with #737. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
jalencato
pushed a commit
that referenced
this pull request
Feb 21, 2024
This is to address the concern brought up here: #737 (comment). It changes the flag name `use-wholegraph-sparse-emb` --> `use-wholegraph-embed`, in consistent with #737. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to review
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.