Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Make SageMaker image build faster and smaller. #731

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

thvasilo
Copy link
Contributor

@thvasilo thvasilo commented Feb 9, 2024

Issue #, if available:

Description of changes:

  • We switch away from using pipenv in the SageMaker image, relying instead on on the poetry-generated requirements.txt file to install dependencies.
  • Also switch to images having prod target by default (although this requires poetry to be installed on the image building environment).
  • Update out-of-date README files.

Testing

Unit tests+Ran a SageMaker job with ml-25m data.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added this to the 0.2.2 Release milestone Feb 9, 2024
@thvasilo thvasilo requested a review from jalencato February 9, 2024 20:58
@thvasilo thvasilo self-assigned this Feb 9, 2024
@thvasilo thvasilo added ready able to trigger the CI gsprocessing For issues and PRs related the the GSProcessing library 0.2.2 labels Feb 9, 2024
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the performance number matches our expectation as well.

@thvasilo thvasilo merged commit 767e929 into awslabs:main Feb 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.2 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants