[Bug fix] Fix the read/delete contention bug when running distributed remaping result/emb #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zheng-da
reviewed
Dec 1, 2023
added 4 commits
November 30, 2023 22:22
zheng-da
approved these changes
Dec 1, 2023
zhjwy9343
reviewed
Dec 2, 2023
| error_and_exit $? | ||
|
|
||
| python3 $GS_HOME/tests/end2end-tests/data_process/check_edge_predict_remap.py --remap-output /tmp/ep_remap/pred/ | ||
|
|
||
| error_and_exit $? | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/pred/src_nids-*.pt | wc -l) | ||
| if test $cnt == 2 |
There was a problem hiding this comment.
Should here be $cnt != 2 or $cnt == 0 to match the then output?
| fi | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/pred/dst_nids-*.pt | wc -l) | ||
| if test $cnt == 2 |
| fi | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/pred/predict-*.pt | wc -l) | ||
| if test $cnt == 2 |
| error_and_exit $? | ||
|
|
||
| python3 $GS_HOME/tests/end2end-tests/data_process/check_edge_predict_remap.py --remap-output /tmp/ep_remap/rename-pred/ --column-names "src_nid,~from:STRING" "dst_nid,~to:STRING" "pred,pred:FLOAT" | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/rename-pred/src_nids-*.pt | wc -l) | ||
| if test $cnt == 0 |
There was a problem hiding this comment.
Should this be $cnt != 0 to match the then output?
| fi | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/rename-pred/dst_nids-*.pt | wc -l) | ||
| if test $cnt == 0 |
| fi | ||
|
|
||
| cnt=$(ls /tmp/ep_remap/rename-pred/predict-*.pt | wc -l) | ||
| if test $cnt == 0 |
zhjwy9343
reviewed
Dec 4, 2023
| error_and_exit $? | ||
|
|
||
| python3 $GS_HOME/tests/end2end-tests/data_process/check_node_predict_remap.py --remap-output /tmp/np_remap/pred/ | ||
|
|
||
| error_and_exit $? | ||
|
|
||
| cnt=$(ls /tmp/np_remap/pred/predict_nids-*.pt | wc -l) | ||
| if test $cnt == 0 |
There was a problem hiding this comment.
Should this be $cnt != 0 to match the echo contents?
| exit -1 | ||
| fi | ||
|
|
||
| cnt=$(ls /tmp/np_remap/pred/predict-*.pt | wc -l) |
| error_and_exit $? | ||
|
|
||
| python3 $GS_HOME/tests/end2end-tests/data_process/check_emb_remap.py --remap-output /tmp/em_remap/partial-emb/ | ||
|
|
||
| error_and_exit $? | ||
|
|
||
| cnt=$(ls /tmp/em_remap/partial-emb/embed_nids-*.pt | wc -l) | ||
| if test $cnt == 2 |
| fi | ||
|
|
||
| cnt=$(ls /tmp/em_remap/partial-emb/embed-*.pt | wc -l) | ||
| if test $cnt == 2 |
| error_and_exit $? | ||
|
|
||
| python3 $GS_HOME/tests/end2end-tests/data_process/check_emb_remap.py --remap-output /tmp/em_remap/partial-rename-emb/ --column-names "nid,~id:STRING" "emb,emb:FLOAT" | ||
|
|
||
| error_and_exit $? | ||
|
|
||
| cnt=$(ls /tmp/em_remap/partial-rename-emb/embed_nids-*.pt | wc -l) | ||
| if test $cnt == 0 |
| fi | ||
|
|
||
| cnt=$(ls /tmp/em_remap/partial-rename-emb/embed-*.pt | wc -l) | ||
| if test $cnt == 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When doing remap_result in a distributed way. It is possible that some processes are still collecting remap tasks (scanning the embedding files and prediction files) while others have finished the tasks and start removing processed files. This will cause an read/delete contention.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.