-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented evaluator for link-prediction in retrieval setting #667
Open
wangz10
wants to merge
11
commits into
awslabs:main
Choose a base branch
from
wangz10:lp_retrieval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangz10
added
the
draft
label only to be used by dev team - skips CI for small changes
label
Nov 27, 2023
zheng-da
reviewed
Nov 30, 2023
@@ -872,6 +872,33 @@ def save_full_node_embeddings(g, save_embed_path, | |||
|
|||
save_shuffled_node_embeddings(shuffled_embs, save_embed_path, save_embed_format) | |||
|
|||
def load_gsgnn_embeddings(emb_path, g): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we didn't have a function to load GNN embeddings saved by GraphStorm? @classicsong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
lp_infer.py
to evaluate a trained link-prediction model in retrieval setting, where all nodes of the target type are used as negative samples. To perform this evaluation:--eval-negative-sampler full
topython3 -m graphstorm.run.gs_link_prediction --inference
--restore-model-path
) and saved GNN embeddings (--restore-embed-path
)GSgnnLinkPredictionRetrievalDataLoader
: a data loader yielding pos pairs onlyload_gsgnn_embeddings
util function to load GNN embeddings from diskLinkPredictDotDecoder.calc_retrieval_scores
: method to compute dot product scores with pos pairs and all embs as neg pairsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.