Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor graphstorm.sagemaker logging printing #650

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

classicsong
Copy link
Contributor

@classicsong classicsong commented Nov 16, 2023

We refactor graphstorm.sagemaker module to use python logging package to print information.
The default logging level is INFO.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong requested a review from thvasilo November 16, 2023 05:55
@classicsong classicsong changed the title Refactor SageMaker graph download logging information. Refactor graphstorm.sagemaker logging printing Nov 28, 2023
@classicsong classicsong added the ready able to trigger the CI label Nov 28, 2023
@classicsong classicsong added this to the 0.2.2 Release milestone Nov 28, 2023
Xiang Song added 2 commits November 27, 2023 18:36
Copy link
Contributor

@thvasilo thvasilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, minor suggestions.

python/graphstorm/sagemaker/sagemaker_infer.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/sagemaker_infer.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/sagemaker_train.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/utils.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/utils.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/sagemaker_infer.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/sagemaker_train.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/utils.py Show resolved Hide resolved
python/graphstorm/sagemaker/utils.py Outdated Show resolved Hide resolved
python/graphstorm/sagemaker/utils.py Show resolved Hide resolved
@classicsong classicsong merged commit 60fa3df into awslabs:main Nov 29, 2023
6 checks passed
@classicsong classicsong deleted the sagemaker-info branch November 29, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants