Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSProcessing] Categorical Feature Transformation #623

Merged
merged 21 commits into from
Nov 9, 2023
Merged

[GSProcessing] Categorical Feature Transformation #623

merged 21 commits into from
Nov 9, 2023

Conversation

jalencato
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jalencato jalencato added this to the 0.2.1 Release Plan. milestone Nov 7, 2023
@jalencato jalencato self-assigned this Nov 7, 2023
@jalencato jalencato linked an issue Nov 7, 2023 that may be closed by this pull request
[GSProcessing] Categorical transformation #573
Closed
@jalencato jalencato added the ready able to trigger the CI label Nov 7, 2023
@jalencato jalencato marked this pull request as ready for review November 7, 2023 18:54
thvasilo
thvasilo requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@thvasilo thvasilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix a couple of issues.

Importantly: Did we test cat and multi-cat with both CSV and Parquet input? We should find a way to do so in our unit tests, possibly by generating Parquet files.

docs/source/gs-processing/developer/input-configuration.rst Outdated Show resolved Hide resolved
docs/source/gs-processing/developer/input-configuration.rst Outdated Show resolved Hide resolved
docs/source/gs-processing/developer/input-configuration.rst Outdated Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/graph_loaders/schema_utils.py Outdated Show resolved Hide resolved
graphstorm-processing/tests/test_converter.py Show resolved Hide resolved
docs/source/gs-processing/developer/input-configuration.rst Show resolved Hide resolved
graphstorm-processing/graphstorm_processing/config/categorical_configs.py Outdated Show resolved Hide resolved
thvasilo
thvasilo approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@thvasilo thvasilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make these two small changes and merge.

docs/source/gs-processing/developer/input-configuration.rst Outdated Show resolved Hide resolved
graphstorm-processing/tests/test_dist_category_transformation.py Outdated Show resolved Hide resolved
@jalencato jalencato merged commit 82f8e20 into awslabs:main Nov 9, 2023
3 checks passed
@jalencato jalencato deleted the gsp_categorical branch September 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thvasilo thvasilo thvasilo approved these changes

Assignees

@jalencato jalencato

Labels
ready able to trigger the CI
Projects
None yet
Milestone
0.2.1 Release Plan.
Development

Successfully merging this pull request may close these issues.

[GSProcessing] Categorical transformation
2 participants
@jalencato @thvasilo