Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way how node embeddings are saved #527

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

classicsong
Copy link
Contributor

@classicsong classicsong commented Oct 5, 2023

Change the way how node embeddings are saved

From
PATH_TO_EMB:
|- emb_info.json
|- ntype0_emb.part00000.bin
|- ...
|- ntype1_emb.part00000.bin
|- ...

To
PATH_TO_EMB:
|- emb_info.json
|- ntype0
|- emb.part00000.bin
|- emb.part00001.bin
|- ...
|- ntype1
|- emb.part00000.bin

Issue #, if available:
#508

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

From
PATH_TO_EMB:
  |- emb_info.json
  |- ntype0_emb.part00000.bin
  |- ...
  |- ntype1_emb.part00000.bin
  |- ...

To
PATH_TO_EMB:
  |- emb_info.json
  |- ntype0
     |- emb.part00000.bin
     |- emb.part00001.bin
     |- ...
  |- ntype1
     |- emb.part00000.bin
@classicsong classicsong requested a review from zhjwy9343 October 5, 2023 00:43
@classicsong classicsong added ready able to trigger the CI 0.2.1 labels Oct 5, 2023
Xiang Song added 2 commits October 4, 2023 23:56
Copy link
Contributor

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@classicsong classicsong merged commit 09cd6d0 into awslabs:id-remap-dev Oct 6, 2023
@classicsong classicsong deleted the update-emb-save branch October 6, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.1 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants