Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Name reverse edges as dst:relation-rev:src #490

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

thvasilo
Copy link
Contributor

Issue #, if available:

Description of changes:

  • We use dst:relation-rev:src for reverse edge names instead of dst:rev-relation:src to match GConstruct.

Testing:

  • pytest and test job (with re-partition follow-up) succeed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…f `dst:rev-relation:src` to match GConstruct.
@thvasilo thvasilo added the ready able to trigger the CI label Sep 26, 2023
@thvasilo thvasilo self-assigned this Sep 26, 2023
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo merged commit b19bdcf into awslabs:main Sep 27, 2023
thvasilo added a commit to thvasilo/graphstorm that referenced this pull request Sep 27, 2023
)

*Issue #, if available:*

*Description of changes:*

* We use `dst:relation-rev:src` for reverse edge names instead of
`dst:rev-relation:src` to match GConstruct.

*Testing*:

* pytest and test job (with re-partition follow-up) succeed


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
thvasilo added a commit to thvasilo/graphstorm that referenced this pull request Sep 28, 2023
)

*Issue #, if available:*

*Description of changes:*

* We use `dst:relation-rev:src` for reverse edge names instead of
`dst:rev-relation:src` to match GConstruct.

*Testing*:

* pytest and test job (with re-partition follow-up) succeed


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
classicsong pushed a commit that referenced this pull request Sep 29, 2023
*Issue #, if available:*

*Description of changes:*

* We use `dst:relation-rev:src` for reverse edge names instead of
`dst:rev-relation:src` to match GConstruct.

*Testing*:

* pytest and test job (with re-partition follow-up) succeed


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready able to trigger the CI v0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants