Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Improve handling of configs with unknown version. #480

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

thvasilo
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Improve the way we handle unknown config versions with more descriptive messages and fall-back parsing.
  • If a version name is not recognized we'll first try to parse the file as GConstruct. If that fails we assume GSProcessing input.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added the ready able to trigger the CI label Sep 25, 2023
@thvasilo thvasilo self-assigned this Sep 25, 2023
@thvasilo thvasilo merged commit 603d481 into awslabs:main Sep 25, 2023
5 checks passed
@thvasilo thvasilo deleted the config-handling branch September 25, 2023 22:50
thvasilo added a commit to thvasilo/graphstorm that referenced this pull request Sep 27, 2023
…labs#480)

*Issue #, if available:*

*Description of changes:*

* Improve the way we handle unknown config versions with more
descriptive messages and fall-back parsing.
* If a version name is not recognized we'll first try to parse the file
as GConstruct. If that fails we assume GSProcessing input.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants