Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SageMaker] Add SageMaker GraphBolt internal implementation #1116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SageMaker] Add SageMaker GraphBolt internal implementation #1116

wants to merge 2 commits into from

Conversation

thvasilo
Copy link
Contributor

Issue #, if available:

Description of changes:

  • The original GraphBolt on SageMaker PR was missing the internal (GSF library) implementation, we only provided the launch script and entry point. This adds the missing module in the GraphStorm library.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added the 0.4 label Dec 18, 2024
@thvasilo thvasilo added this to the 0.4 release milestone Dec 18, 2024
@thvasilo thvasilo requested a review from jalencato December 18, 2024 18:44
@thvasilo thvasilo self-assigned this Dec 18, 2024
@thvasilo thvasilo added the ready able to trigger the CI label Dec 18, 2024
jalencato
jalencato reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test on SageMaker for this PR's newly introduced function?

python/graphstorm/sagemaker/sagemaker_gb_convert.py Outdated Show resolved Hide resolved
@thvasilo
Copy link
Contributor Author

Do we have a test on SageMaker for this PR's newly introduced function?

You mean a regression test? I don't think we have any unit test for any of the sagemaker code.

@thvasilo thvasilo requested a review from jalencato December 19, 2024 21:07
@jalencato
Copy link
Collaborator

Do we have a test on SageMaker for this PR's newly introduced function?

You mean a regression test? I don't think we have any unit test for any of the sagemaker code.

I mean we add a new regression test after we merge this PR, as no current unit test covers the function here.

jalencato
jalencato approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalencato jalencato jalencato approved these changes

Assignees

@thvasilo thvasilo

Labels
0.4 ready able to trigger the CI sagemaker
Projects
None yet
Milestone
0.4 release
Development

Successfully merging this pull request may close these issues.
2 participants
@thvasilo @jalencato