Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix issue #1052 #1105

Merged
merged 9 commits into from
Dec 5, 2024
Merged

[Fix] Fix issue #1052 #1105

merged 9 commits into from
Dec 5, 2024

Conversation

zhjwy9343
Copy link
Contributor

@zhjwy9343 zhjwy9343 commented Dec 3, 2024

Issue #, if available:
#1052

Description of changes:
This PR adds additional information for users to use the workspace configuration. Also change the format of HINT to Note.

Preview of configuration: https://james4graphstorm.readthedocs.io/en/james_1052/cli/model-training-inference/configuration-run.html
Preview of quick-start: https://james4graphstorm.readthedocs.io/en/james_1052/tutorials/quick-start.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhjwy9343 zhjwy9343 added enhancement New feature or request ready able to trigger the CI 0.4 labels Dec 3, 2024
@zhjwy9343 zhjwy9343 requested a review from Oxfordblue7 December 3, 2024 01:07
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update https://graphstorm.readthedocs.io/en/latest/tutorials/quick-start.html#launch-training? to create the /tmp/ogbn-arxiv-nc workspace before call the graphstorm.run.gs_node_classification command?

@zhjwy9343
Copy link
Contributor Author

zhjwy9343 commented Dec 3, 2024

Can you also update https://graphstorm.readthedocs.io/en/latest/tutorials/quick-start.html#launch-training? to create the /tmp/ogbn-arxiv-nc workspace before call the graphstorm.run.gs_node_classification command?

Sure, updated with additional lines. See the preview links for the rendered pages.

Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhjwy9343 zhjwy9343 merged commit 30bf519 into awslabs:main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4 enhancement New feature or request ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants