Add support for ParMETIS to local Dockerfile #1102
Conversation
| @@ -1,4 +1,5 @@ | |||
| ARG DEVICE=gpu | |||
There was a problem hiding this comment.
Have you got any number about time to build the docker image here? I think a big burden here is that the time for building parmetis docker image will be too long, and also make the docker image itself too large.
There was a problem hiding this comment.
ParMETIS dependencies are or added if requested by the user, the build time should be roughly the same as building the ParMETIS image using the specialized Dockerfile.
Could you clarify if there's a concern I'm missing here? I will add some measurements of build times for the images using the specialized Dockerfile vs. this one.
| # Copy GraphStorm scripts and tools | ||
| COPY code/examples /graphstorm/examples | ||
| COPY code/inference_scripts /graphstorm/inference_scripts | ||
| COPY code/tools /graphstorm/tools | ||
| COPY code/training_scripts /graphstorm/training_scripts | ||
| COPY code/fetch_and_run.sh /graphstorm/fetch_and_run.sh | ||
| RUN chmod +x "/graphstorm/fetch_and_run.sh" |
There was a problem hiding this comment.
Any reason we need to do this now?
| @@ -33,6 +33,13 @@ else | |||
| DEVICE_TYPE="$4" | |||
| fi | |||
|
|
|||
| # process argument 5: support for parmetis | |||
| if [ -z "$4" ]; then | |||
| USE_PARMETIS="false" | |||
There was a problem hiding this comment.
We better to note the option here in the doc. We have changed the way to build docker image here.
|
Removed 0.4 tag as we can merge this after the release, not urgent. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.