Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Add saving and re-applying for numerical transforms. #1085

Merged
merged 6 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/source/cli/graph-construction/distributed/example.rst
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,9 @@ the graph structure, features, and labels. In more detail:
GSProcessing will use the transformation values listed here
instead of creating new ones, ensuring that models trained with the original
data can still be used in the newly transformed data. Currently only
categorical transformations can be re-applied.
categorical and numerical transformations can be re-applied. Note that
the Rank-Gauss transformation does not support re-application, it may
only work for transductive tasks.
* ``updated_row_counts_metadata.json``:
This file is meant to be used as the input configuration for the
distributed partitioning pipeline. ``gs-repartition`` produces
Expand Down Expand Up @@ -313,7 +315,7 @@ you can use the following command to run the partition job locally:
--num-parts 2 \
--dgl-tool-path ./dgl/tools \
--partition-algorithm random \
--ip-config ip_list.txt
--ip-config ip_list.txt

The command above will first do graph partitioning to determine the ownership for each partition and save the results.
Then it will do data dispatching to physically assign the partitions to graph data and dispatch them to each machine.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
)


class DistFeatureTransformer(object):
class DistFeatureTransformer:
"""
Given a feature configuration selects the correct transformation type,
which can then be be applied through a call to apply_transformation.
Expand All @@ -56,7 +56,9 @@ def __init__(
if feat_type == "no-op":
self.transformation = NoopTransformation(**default_kwargs, **args_dict)
elif feat_type == "numerical":
self.transformation = DistNumericalTransformation(**default_kwargs, **args_dict)
self.transformation = DistNumericalTransformation(
**default_kwargs, **args_dict, json_representation=json_representation
)
elif feat_type == "multi-numerical":
thvasilo marked this conversation as resolved.
Show resolved Hide resolved
self.transformation = DistMultiNumericalTransformation(**default_kwargs, **args_dict)
elif feat_type == "bucket-numerical":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def get_transformation_name() -> str:
return "DistBucketNumericalTransformation"

def apply(self, input_df: DataFrame) -> DataFrame:
imputed_df = apply_imputation(self.cols, self.shared_imputation, input_df)
imputed_df = apply_imputation(self.cols, self.shared_imputation, input_df).imputed_df
# TODO: Make range optional by getting min/max from data.
min_val, max_val = self.range

Expand Down
Loading
Loading