[Enhancement] Add a strict naming rule for graph names #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classicsong
added
enhancement
zhjwy9343
reviewed
Sep 26, 2024
docs/source/cli/graph-construction/single-machine-gconstruct.rst
Outdated
Show resolved
Hide resolved
thvasilo
requested changes
Sep 26, 2024
graphstorm-processing/graphstorm_processing/distributed_executor.py
Outdated
Show resolved
Hide resolved
…or.py Co-authored-by: Theodore Vasiloudis <[email protected]>
Co-authored-by: Theodore Vasiloudis <[email protected]>
thvasilo
approved these changes
Sep 26, 2024
thvasilo
added a commit
that referenced
this pull request
Oct 1, 2024
*Issue #, if available:* *Description of changes:* * GSProcessing makes providing a graph name optional. After #1044 we were checking the graph name before we filled in default values. * We now provide a default value before the name validity check. * Added some tests to check various graph naming cases. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#957
Description of changes:
The graph name must adhere to the Python identifier naming rules, with one exception that hyphens (-) are permitted.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.