Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Xiang Song committed Jun 7, 2024
1 parent 19f2bd9 commit f07cbd5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflow_scripts/e2e_mgpu_check.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Move to parent directory
cd ../../

pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com pylibwholegraph-cu11
pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com pylibwholegraph-cu11==24.4.0

set -ex

Expand Down
6 changes: 3 additions & 3 deletions python/graphstorm/dataloading/dataloading.py
Original file line number Diff line number Diff line change
Expand Up @@ -1280,10 +1280,10 @@ def __next__(self):
return cur_iter, self._neg_sample_type

def __len__(self):
num_samples = 0
num_iters = 0
for _, test_size in self._fixed_test_size.items():
num_samples += math.ceil(test_size / self._batch_size)
return num_samples
num_iters += math.ceil(test_size / self._batch_size)
return num_iters

@property
def fanout(self):
Expand Down
6 changes: 3 additions & 3 deletions tests/end2end-tests/data_gen/movielens_multi_task.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@
{
"task_type": "link_prediction",
"split_pct": [0.1, 0.1, 0.1],
"mask_field_names": ["train_mask_field_l",
"val_mask_field_l",
"test_mask_field_l"]
"mask_field_names": ["train_mask_field_lp",
"val_mask_field_lp",
"test_mask_field_lp"]
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ gsf:
batch_size: 128 # will overwrite the global batch_size
mask_fields:
- "train_mask_field_lp"
- "val_mask_field_l" # empty means there is no validation mask
- "val_mask_field_lp" # empty means there is no validation mask
- null # empty means there is no test mask
task_weight: 1.0
- reconstruct_node_feat:
Expand Down

0 comments on commit f07cbd5

Please sign in to comment.