Review comments

awslabs · Jul 1, 2024 · db38b9a · db38b9a
1 parent 2dfb0b7
commit db38b9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docs/source/gs-processing/usage/emr.rst b/docs/source/gs-processing/usage/emr.rst
@@ -143,7 +143,7 @@ using the above Python script.
     S3_ENTRY_POINT="s3://${OUTPUT_BUCKET}/emr-scripts/distributed_executor.py"
     aws s3 cp "${PATH_TO_ENTRYPOINT}" ${S3_ENTRY_POINT}
 
-    OUTPUT_PREFIX="s3://${OUTPUT_BUCKET}/gsprocessing/emr/${GRAPH_NAME}/"
+    OUTPUT_PREFIX="s3://${OUTPUT_BUCKET}/gsprocessing/emr/${GRAPH_NAME}"
 
     python "${SCRIPT_DIR}/submit_gsp_emr_step.py" \
         --entry-point-s3 ${S3_ENTRY_POINT} \

diff --git a/graphstorm-processing/scripts/submit_gsp_emr_step.py b/graphstorm-processing/scripts/submit_gsp_emr_step.py
@@ -60,7 +60,7 @@ def parse_args():
         "--worker-count",
         type=int,
         required=True,
-        help="Number of worker (core) instances. Required",
+        help="Number of worker instances. Required",
     )
     parser.add_argument(
         "--instance-type",
@@ -74,7 +74,7 @@ def parse_args():
     )
     parser.add_argument(
         "--service-role",
-        default="EMR_DefaultRole",
+        default="EMR_DefaultRole_V2",
         help="EMR service role to use for the EMR cluster. Defaults to EMR_DefaultRole.",
     )
     parser.add_argument(