Skip to content

Commit

Permalink
Add comments from review
Browse files Browse the repository at this point in the history
  • Loading branch information
thvasilo committed Nov 14, 2024
1 parent dfab7ca commit 49d9192
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class ImputationResult:
Structure:
imputed_val_dict: dict[str, float]
The imputed values for each column, {col_name: imputation_val}.
Empty if no imputation was applied.
Will be an empty dict if no imputation was applied.
imputer_name: str
The name of imputer used.
"""
Expand Down Expand Up @@ -192,8 +192,8 @@ def apply_norm(
A dataclass containing the normalized DataFrame with only the
columns listed in ``cols`` retained in the ``scaled_df`` element,
and a dict representation of the transformation in the ``normalization_representation``
variable. The inner structure of ``normalization_representation`` depends on normalizers, see ``NormalizationResult`` docstring
for details.
variable. The inner structure of ``normalization_representation`` depends on normalizers,
see ``NormalizationResult`` docstring for details.
Raises
------
Expand Down Expand Up @@ -584,6 +584,7 @@ def apply_precomputed_transformation(self, input_df: DataFrame) -> DataFrame:
)

cols = self.json_representation["cols"]
# All cols share the same imputer and normalizer
impute_representation = self.json_representation["imputer_model"]
norm_representation = self.json_representation["normalizer_model"]
out_dtype = self.json_representation.get("out_dtype", TYPE_FLOAT32)
Expand Down

0 comments on commit 49d9192

Please sign in to comment.