Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
thvasilo committed Nov 10, 2023
1 parent 0bf95e3 commit 2136575
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 51 deletions.
15 changes: 10 additions & 5 deletions docs/source/gs-processing/usage/distributed-processing-setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,13 @@ for more information.
Support for arm64 architecture
------------------------------

You might have noticed that we include the image's architecture, ``x86_64`` in the image name.
For EMR Serverless images, it is possible to build images that support ``arm64`` instances,
which can lead to improved runtime and cost compared to ``x86_64``. To build ``arm64`` images
which can lead to improved runtime and cost compared to ``x86_64``. You can build an ``arm64``
image natively by installing Docker and following the above process on an ARM instance such
as ``M6G`` or ``M7G``. See the `AWS documentation <https://aws.amazon.com/ec2/graviton/>`_
for instances powered by the Graviton processor.

To build ``arm64`` images
on an ``x86_64`` host you need to enable multi-platform builds for Docker. The easiest way
to do so is to use QEMU emulation. To install the QEMU related libraries you can run

Expand Down Expand Up @@ -159,9 +163,10 @@ To build an EMR Serverless GSProcessing image for the ``arm64`` architecture you

Building images under emulation using QEMU can be significantly slower than native builds
(more than 20 minutes to build the GSProcessing ``arm64`` image).
To speed up the build process you can look into using ``buildx`` with multiple native nodes,
or cross-compilation.
See `the official Docker documentation <https://docs.docker.com/build/building/multi-platform/>`_ for details.
To speed up the build process you can build on an ARM instances,
look into using ``buildx`` with multiple native nodes, or use cross-compilation.
See `the official Docker documentation <https://docs.docker.com/build/building/multi-platform/>`_
for details.

Push the image to the Amazon Elastic Container Registry (ECR)
-------------------------------------------------------------
Expand Down
45 changes: 0 additions & 45 deletions graphstorm-processing/docker/0.2.1/sagemaker/Dockerfile.cpu

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
],
"separator": ","
},
"type": "movies",
"type": "movie",
"column": "~id"
},
{
Expand Down

0 comments on commit 2136575

Please sign in to comment.