Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export Trino metrics to Prometheus and enable autoscalling with KEDA #712

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bbgu1
Copy link
Contributor

@bbgu1 bbgu1 commented Dec 4, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Scaling Trino workers with KEDA and metrics in Prometheus

Motivation

Enable Trino auto-scaling by tracking metrics such as cpu, memory pressure, and queued queries.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

  • using latest version of trino and trino helm chart
  • enabled jmx exporter and servicemonitor to both coordinator and workers.
  • deploying scaledobject for trino-worker in terraform

@bbgu1 bbgu1 changed the title feat: Export Trino metrics to Prometheus feat: Export Trino metrics to Prometheus, enable autoscalling with KEDA Dec 4, 2024
@bbgu1 bbgu1 requested a review from vara-bonthu December 4, 2024 20:27
Copy link
Collaborator

@ratnopamc ratnopamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bbgu1.
Could you please update the website doc and add a section with the instructions to test the scaling with KEDA in action?

@ratnopamc ratnopamc changed the title feat: Export Trino metrics to Prometheus, enable autoscalling with KEDA feat: Export Trino metrics to Prometheus and enable autoscalling with KEDA Dec 19, 2024
Add comments
@ratnopamc
Copy link
Collaborator

Thanks for the PR @bbgu1. Could you please update the website doc and add a section with the instructions to test the scaling with KEDA in action?

@bbgu1 will raise a separate PR with documentation updates and load testing script.

@ratnopamc ratnopamc self-requested a review December 19, 2024 20:19
Copy link
Collaborator

@ratnopamc ratnopamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants