Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add all VPC CIDRs to VPCe config #697

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

alanty
Copy link
Contributor

@alanty alanty commented Nov 4, 2024

What does this PR do?

Adds the public subnet CIDR blocks to the security group on the VPC endpoints and adds the S3 gateway endpoint to the Public route table.

Motivation

I launched an instance in the Spark operator VPC to use as a bastion instance and selected the Public subnets but the SSM agent on the instance never connected. I think when the vpc endpoints are enabled, the SSM endpoint overrides the DNS for the service, but the Security group blocks traffic from the public subnet.

This shouldn't cause a problem for our examples/eks nodes as we don't really leverage the Public subnet but was annoying to debug.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

@vara-bonthu vara-bonthu merged commit ad50d57 into awslabs:main Nov 4, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants