Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect command to provide Linux permission on the AWS Trainium on EKS Blueprint #533 #542

Merged
merged 2 commits into from
May 29, 2024

Conversation

AbrahamArellano
Copy link
Contributor

… Trainium on EKS Blueprint #533

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

There is a typo in the following commands on the Blueprint for AWS Trainium on EKS:

https://awslabs.github.io/data-on-eks/docs/blueprints/ai-ml/trainium
The wrong commands are:
chomd +x 1-bert-pretrain-build-image.sh
chomd +x 2-bert-pretrain-precompile.sh

The correct version should be:
chmod +x 1-bert-pretrain-build-image.sh
chmod +x 2-bert-pretrain-precompile.sh

Motivation

I'm part of the AWS Container TFC and a Solution Architect working with customers promoting this blueprint.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?
    Yes

Additional Notes

@AbrahamArellano
Copy link
Contributor Author

I'm also addressing the following issue here:

@AbrahamArellano AbrahamArellano changed the title Fixed issue: Incorrect command to provide Linux permission on the AWS Trainium on EKS Blueprint #533 fix: Incorrect command to provide Linux permission on the AWS Trainium on EKS Blueprint #533 May 29, 2024
@vara-bonthu vara-bonthu merged commit 6331e96 into awslabs:main May 29, 2024
2 of 3 checks passed
ovaleanu pushed a commit to ovaleanu/data-on-eks that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants