chore: Clean up pre-commit warnings and delays #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added excalidraw to codespell ignore Remove terraform validate from pre-commit, developers should run this themselves.
vara-bonthu
reviewed
Apr 8, 2024
Comment on lines
-34
to
-35
| - id: terraform_validate | ||
| exclude: docs |
There was a problem hiding this comment.
@bryantbiggs Is this step used in any of the pre-commit GitHub workflows? What is your recommendation here?
There was a problem hiding this comment.
if your CI is already running a terraform plan on each pattern, then this could be considered redundant
I also don't see pre-commit as a CI check which is why I guess a lot of these white space/noise changes are occurring on subsequent PRs
vara-bonthu
reviewed
Apr 8, 2024
| @@ -1,5 +1,5 @@ | |||
| [codespell] | |||
| skip = .git,*.pdf,*.svg,go.sum,package-lock.json,*.css,.codespellrc,*.sql,website/package-lock.json | |||
| skip = .git,*.pdf,*.svg,go.sum,package-lock.json,*.css,.codespellrc,*.sql,website/package-lock.json,*.excalidraw | |||
vara-bonthu
approved these changes
Apr 8, 2024
vara-bonthu
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit 65d1709.
ovaleanu
pushed a commit
to ovaleanu/data-on-eks
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added excalidraw to codespell ignore
Remove terraform validate from pre-commit, developers should run this themselves.
Motivation
Terraform validate in the precommit takes absolutely forever on the root of the project. Everyone is skipping it or aborting it. So let's remove it.
Finally, excalidraw always comes up in spelling check output. Let's add that to ignore.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes