Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in the cleanup script #462

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fix: Fix typo in the cleanup script #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ai-ml/jark-stack/terraform/cleanup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ echo "Destroying RayService..."

# Delete the Ingress/SVC before removing the addons
TMPFILE=$(mktemp)
terraform -chdir=$SCRIPTDIR output -raw configure_kubectl > "$TMPFILE"
terraform output -raw configure_kubectl > "$TMPFILE"
# check if TMPFILE contains the string "No outputs found"
if [[ ! $(cat $TMPFILE) == *"No outputs found"* ]]; then
echo "No outputs found, skipping kubectl delete"
Expand Down Expand Up @@ -65,7 +65,7 @@ for sg in $(aws ec2 describe-security-groups \

## Final destroy to catch any remaining resources
echo "Destroying remaining resources..."
destroy_output=$(terraform destroy -var="region=$region"-auto-approve 2>&1 | tee /dev/tty)
destroy_output=$(terraform destroy -var="region=$region" -auto-approve 2>&1 | tee /dev/tty)
if [[ ${PIPESTATUS[0]} -eq 0 && $destroy_output == *"Destroy complete"* ]]; then
echo "SUCCESS: Terraform destroy of all modules completed successfully"
else
Expand Down
1 change: 1 addition & 0 deletions ai-ml/jark-stack/terraform/src/service/ray-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ spec:
importPath: dogbooth:entrypoint
runtimeEnv: |
env_vars: {"MODEL_ID": "askulkarni2/dogbooth"}
#env_vars: {"MODEL_ID": "stabilityai/stable-diffusion-2-1"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to use both models? This looks like commented

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I left there as an example for using upstream model if someone wants to test it.

rayClusterConfig:
rayVersion: '2.6.0'
headGroupSpec:
Expand Down
Loading