feat: Argo Workflow blueprint upgrade to latest Karpenter #459
Conversation
There was a problem hiding this comment.
@ovaleanu Thanks for the upgrade 👍🏼 I left couple of comments .
| @@ -1,109 +1,111 @@ | |||
| apiVersion: karpenter.sh/v1alpha5 | |||
There was a problem hiding this comment.
This is new way of deploying Karpenter provisioners which uses a local Helm Chart from EKS Data Add-ons
https://github.com/awslabs/data-on-eks/blob/1e4b51971bed042adf17cb7995cceafb7790a150/analytics/terraform/spark-k8s-operator/addons.tf#L180C1-L184C1
If you have bandwidth, then you can leverage the above approach or raise another PR for the upgrade. I am fine with either approach.
There was a problem hiding this comment.
I have seen this as well. I can use this approach.
| karpenter_node = { | ||
| iam_role_use_name_prefix = false | ||
| iam_role_name = "${local.name}-karpenter-node" | ||
| iam_role_additional_policies = { | ||
| AmazonSSMManagedInstanceCore = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore" | ||
| } | ||
| } |
There was a problem hiding this comment.
Check this code where we are not defining iam_role_name.
iam role is being passed to the Karpenter provisioner here
There was a problem hiding this comment.
I saw this, but if the provisioner is in a file separately and not embedded in the addons.tf, then it doesn't know who is "module".
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Upgrade Karpenter version for Argo Workflow blueprint
Motivation
#413
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes