Aligned provided output to match the command shown (Ray install validation) #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides clarity for the verification steps for installing Ray. (It is currently confusing as the output does not match the command suggested)
Command given
output provided
As you can see the output is showing other namespaces (the output from
kubectl get pods -A
likely.🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
I have cleaned up the example output to match the command.
Motivation
Accuracy. Also with this nuanced erroneous output, it gives the impression that you should be seeing numerous pods when you run the command (which is not the case), and as a result, you may conclude (as I had) that there is something wrong.
More
website/docs
orwebsite/blog
section for this featurepre-commit run -a
with this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes