Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned provided output to match the command shown (Ray install validation) #391

Merged

Conversation

jaradtke-aws
Copy link
Contributor

What does this PR do?

This PR provides clarity for the verification steps for installing Ray. (It is currently confusing as the output does not match the command suggested)

Command given

kubectl get pods -n kuberay-operator

output provided

NAMESPACE            NAME                               READY   STATUS    RESTARTS        AGE
amazon-cloudwatch    aws-cloudwatch-metrics-d4xrr       1/1     Running   1 (1h37m ago)   1h
amazon-cloudwatch    aws-cloudwatch-metrics-tpqsz       1/1     Running   1 (1h37m ago)   1h
....

As you can see the output is showing other namespaces (the output from kubectl get pods -A likely.

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

I have cleaned up the example output to match the command.

kubectl get pods -n kuberay-operator
NAME                               READY   STATUS    RESTARTS        AGE
kuberay-operator-7b5c85998-vfsjr   1/1     Running   1 (1h37m ago)   1h

Motivation

Accuracy. Also with this nuanced erroneous output, it gives the impression that you should be seeing numerous pods when you run the command (which is not the case), and as a result, you may conclude (as I had) that there is something wrong.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@jaradtke-aws jaradtke-aws changed the title Aligned provided output to match the command shown Aligned provided output to match the command shown (Ray install validation) Jan 9, 2024
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit 461ac25 into awslabs:main Jan 17, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants