Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add EMR runtime for flink operator blueprint #345

Closed
wants to merge 2 commits into from
Closed

feat: Add EMR runtime for flink operator blueprint #345

wants to merge 2 commits into from

Conversation

lmouhib
Copy link
Contributor

@lmouhib lmouhib commented Oct 11, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@lmouhib lmouhib temporarily deployed to DoEKS Test October 11, 2023 19:18 — with GitHub Actions Inactive
@lmouhib lmouhib changed the title feat: emr runtime for flink operator blueprint feat: Add EMR runtime for flink operator blueprint Oct 11, 2023
@lmouhib lmouhib marked this pull request as draft October 11, 2023 19:21
vara-bonthu
vara-bonthu reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmouhib Raise a PR if this is ready. One change required

streaming/emr-flink-karpenter/addons.tf
# EMR Runtime Flink Operator Add-On
#---------------------------------------------------------------
enable_emr_flink_operator = true
flink_operator_helm_config = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be emr_flink_operator_helm_config ?

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Nov 30, 2023
@lmouhib lmouhib added enhancement New feature or request help wanted Extra attention is needed and removed stale labels Dec 11, 2023
@lmouhib lmouhib reopened this Dec 11, 2023
@vara-bonthu
Copy link
Collaborator

This blueprint is now merged with #637 so closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu left review comments

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmouhib @vara-bonthu