Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct instanceFamily for Trainium #339

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

askulkarni2
Copy link
Collaborator

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Uses correct instance family in the karpenter provisioner for Trainium instances.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 temporarily deployed to DoEKS Test October 6, 2023 23:49 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 marked this pull request as ready for review October 6, 2023 23:49
@vara-bonthu vara-bonthu merged commit 2267657 into main Oct 7, 2023
@askulkarni2 askulkarni2 deleted the askulkarni2-patch-1 branch October 7, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants