Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MLflow Tracking blueprint #334

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Conversation

ovaleanu
Copy link
Contributor

@ovaleanu ovaleanu commented Oct 4, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

This PR adds a blueprints for deploying MLFlow Tracking on Amazon EKS.
MLflow Tracking is an API and UI for logging parameters, code versions, metrics, and artifacts when running your machine learning code and for later visualizing the results.

Motivation

Resolve #16

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 4, 2023 14:28 — with GitHub Actions Inactive
@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 4, 2023 16:28 — with GitHub Actions Inactive
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left few minor comments

# backend "s3" {
# bucket = "doeks-github-actions-e2e-test-state"
# region = "us-west-2"
# key = "e2e/argo-workflow/terraform.tfstate"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change argo-workflow to mflow

#---------------------------------------
# NVIDIA Device Plugin Add-on
#---------------------------------------
nvidia-device-plugin = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Data Addons module for this add-on

}

data "aws_availability_zones" "available" {}
# data "aws_region" "current" {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this commented line

Copy link
Contributor

github-actions bot commented Nov 9, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 9, 2023
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Nov 19, 2023
@ovaleanu ovaleanu added enhancement New feature or request and removed stale labels Dec 12, 2023
@ovaleanu ovaleanu self-assigned this Dec 12, 2023
@askulkarni2 askulkarni2 merged commit 8b8d02f into awslabs:main Dec 13, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] MLFlow on Amazon EKS
3 participants