Add job document comparator to ignore pre-signed difference in s3 url #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated versions in build.yml for aws credential fetch
tony-josi-aws
previously requested changes
Nov 11, 2024
amazonKamath
approved these changes
Nov 13, 2024
amazonKamath
approved these changes
Nov 13, 2024
tony-josi-aws
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently 2 job documents containing the same s3 pre-signed url that are sent from the console are compared directly in string formatting. After these changes the 2 job documents will be compared neglecting the aws temporary access signature, to avoid 2 identical job documents with different signatures being considered different and creating conflicts on the device processes
Modifications
Change summary
Please describe what changes are included in this pull request.
Added a comparator function to replace the pre-signed part of an s3 pre-signed url with a common placeholder to avoid
same job with different pre-signed parts to be inferred differently by device client
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
Changes tested locally by simulating different cases for the job documents.
Manually tested the output against customer job document and handler files as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.