-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Cognito credential provider support #306
Open
xiazhvera
wants to merge
17
commits into
secitem_bindings
Choose a base branch
from
cognito_support
base: secitem_bindings
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b3be803
add cognito credential provider support
xiazhvera 70e4dd6
Merge branch 'secitem_bindings' of https://github.com/awslabs/aws-crt…
xiazhvera 732e885
fix test name
xiazhvera af00a88
fix shutdown flag
xiazhvera 3e17395
skip the test if env is not set
xiazhvera d4c6b07
swift lint format
xiazhvera cddd848
test with new env var
xiazhvera 3ac6ec0
set use xcodebuild
xiazhvera 5b3d2a5
remove cognito test
xiazhvera 5eb25e9
waiting for shutdown credential provider
xiazhvera eb57164
add scope to make sure the provider released
xiazhvera d982864
setup ci for xcodebuild
xiazhvera 3b3ded9
Merge branch 'iot_ci_env_var' of https://github.com/awslabs/aws-crt-s…
xiazhvera 95487a4
[WIP]cognito test
xiazhvera 59ac4e4
WIP remove test vars
xiazhvera 4b84fcb
add cognito connecton test
xiazhvera 1895e9a
fix spacing...
xiazhvera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import Builder | ||
|
||
class CrtCiPrepXCodebuild(Builder.Action): | ||
def run(self, env): | ||
env.shell.setenv("TEST_RUNNER_AWS_TESTING_STS_ROLE_ARN", env.shell.get_secret("aws-c-auth-testing/sts-role-arn")) | ||
actions = [ | ||
Builder.SetupCrossCICrtEnvironment(use_xcodebuild=True) | ||
] | ||
return Builder.Script(actions, name='crt-ci-prep-xcodebuild') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
286 changes: 204 additions & 82 deletions
286
Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift
Large diffs are not rendered by default.
Oops, something went wrong.
205 changes: 125 additions & 80 deletions
205
Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the PR but can we avoid adding this action in crt-swift? We don't need to test the Cognito credential provider functionality in bindings; we can just create/destroy it for simple binding tests. The MQTT-specific tests should be in the IoT SDK.
This action makes it harder to run these tests locally. I think we will likely need this action for MQTT unit tests but we should try to avoid it if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script change is used to allow passing environment variables into xcodebuild tests. Regardless of the Cognito credential provider changes, we still need it for the unit tests that requires environment variables.