Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix String Decode Crash #223

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix String Decode Crash #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0fb27
try to decode instead of force decode
waahm7 Jan 17, 2024
083ac44
For toOptionalStrings which is used for credentials, don't replace it…
waahm7 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/AwsCommonRuntimeKit/crt/Utilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ extension aws_byte_cursor {
}

let data = Data(bytesNoCopy: self.ptr, count: self.len, deallocator: .none)
return String(data: data, encoding: .utf8)!
return String(decoding: data, as: UTF8.self)
}

func toOptionalString() -> String? {
if self.len == 0 { return nil }
let data = Data(bytesNoCopy: self.ptr, count: self.len, deallocator: .none)
return String(data: data, encoding: .utf8)!
return String(data: data, encoding: .utf8)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used for the credential's access key, secret access key, and session token. We don't want partial characters in this case.

}
}

Expand Down