WriteChunk API for HTTP1 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
commented
Jan 8, 2024
| @@ -3,7 +3,7 @@ | |||
| import AwsCHttp | |||
| import Foundation | |||
|
|
|||
| /// An base class that represents a single Http Request/Response for both HTTP/1.1 and HTTP/2. | |||
| /// An base abstract class that represents a single Http Request/Response for both HTTP/1.1 and HTTP/2. | |||
| /// Can be used to update the Window size, and get status code. | |||
| public class HTTPStream { | |||
There was a problem hiding this comment.
I thought about turning this class into a protocol to avoid the abstract class workaround with fatalAssert, but that would require making rawValue and callbackData variables public.
graebm
reviewed
Jan 8, 2024
|
|
||
|
|
||
| /// This method must be overriden in each subclass. | ||
| public func writeChunk(chunk: Data, endOfStream: Bool) async throws { |
There was a problem hiding this comment.
mildly annoyed by calling this "chunk"
"chunk" is an HTTP/1-specific term
| @@ -41,7 +41,12 @@ public class HTTPStream { | |||
| throw CommonRunTimeError.crtError(.makeFromLastError()) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| /// This method must be overriden in each subclass. | |||
There was a problem hiding this comment.
is this how interface functions are supposed to be documented? doesn't seem very useful to the user
Should this document how you have to set up the connection with "use manual data writes" or "transfer-encoding: chunked" depending on whether it's HTTP/1 or HTTP/2?
There was a problem hiding this comment.
I have updated the documentation to link to the H1 and H2 documentation.
graebm
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#218
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.