Use Public Domain PKCS#11 headers, to avoid OASIS license #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
force-pushed
the
pkcs11-headers
branch
from
9429083 to
2a4aa5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 28 28
Lines 5949 5949
=======================================
Hits 4762 4762
Misses 1187 1187 ☔ View full report in Codecov by Sentry. |
waahm7
approved these changes
Feb 12, 2024
alfred2g
pushed a commit
that referenced
this pull request
May 21, 2024
**Issue #:** #621 The OASIS IPR license is not on Fedora's approved license list. This license is at the top of the PKCS#11 headers released by the OASIS technical committee that standardizes PKCS#11. So it's a good idea to use the official headers, right? No, wrong, apparently. [Here](latchset/pkcs11-provider#76) [are](tpm2-software/tpm2-pkcs11#338) [many](softhsm/SoftHSMv2#412) [other](https://gitlab.isc.org/isc-projects/bind9/-/issues/414) [open](containers/podman#13906) [source](https://mail.openjdk.org/pipermail/jdk-dev/2021-May/005526.html) [projects](https://lists.fedoraproject.org/archives/list/[email protected]/thread/2QXHMTZ47DMMARJVI6PUMSYUPVFAGLCV/) being confused by the license, and replacing the headers that container it. **Description of changes:** Replace OASIS headers with public domain headers, sourced from https://github.com/latchset/pkcs11-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #621 The OASIS IPR license is not on Fedora's approved license list.
This license is at the top of the PKCS#11 headers released by the OASIS technical committee that standardizes PKCS#11. So it's a good idea to use the official headers, right? No, wrong, apparently. Here are many other open source projects being confused by the license, and replacing the headers that container it.
Description of changes: Replace OASIS headers with public domain headers, sourced from https://github.com/latchset/pkcs11-headers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.