Remove unused dependencies #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Celebrate-future . I will do some testing on my end to confirm the changes and get back ASAP. |
|
@disa6302 Thanks for your feedback :) |
disa6302
reviewed
Feb 16, 2021
pom.xml
Outdated
| <groupId>com.amazonaws</groupId> | ||
| <artifactId>amazon-kinesis-video-streams-producer-sdk-java</artifactId> | ||
| <name>Amazon Kinesis Video Streams Producer SDK Java</name> | ||
| <version>1.10.0</version> |
There was a problem hiding this comment.
The current version is 1.11.0. Can you please change the version back to that?
There was a problem hiding this comment.
OK. I will change it back.
|
The changes work. I tested it out. One comment : We are on version 1.11.0. Please change it from 1.10.0 to 1.11.0 in the PR and we are all set to merge this. |
|
I have already changed the version back to 1.11.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@disa6302 Hi, I am a user of project com.amazonaws:amazon-kinesis-video-streams-producer-sdk-java:1.10.0. I found that its pom file introduced 47 dependencies. However, among them, 9 libraries (19%) have not been used by your project (the redundant dependencies are listed below). This PR helps com.amazonaws:amazon-kinesis-video-streams-producer-sdk-java:1.10.0 lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.
Best regards
Redundant dependencies----
Outdated dependencies
org.codehaus.mojo:animal-sniffer-annotations:1.17 (1863 days without maintenance)
javax.inject:javax.inject:1 (5036 days without maintenance)
com.google.j2objc:j2objc-annotations:1.1 (2558 days without maintenance)
com.google.inject.extensions:guice-multibindings:4.2.3 (1226 days without maintenance)
com.amazonaws:jmespath-java:1.11.602 (1459 days without maintenance)