Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integration): update well-known-endpoints #4929

Closed
wants to merge 1 commit into from

Conversation

goatgoose
Copy link
Contributor

@goatgoose goatgoose commented Nov 22, 2024

Description of changes:

www.microsoft.com started returning 403 status codes in the rust well-known-endpoints test:
https://github.com/aws/s2n-tls/actions/runs/11966043763/job/33361030837?pr=4926

However, when I run this test locally I get a 200 response. I think this may mean that this endpoint is throttling the HTTP requests from CI?

Call-outs:

Changing the expected status code to 403 causes the test to fail locally, since a 200 code is returned. So I instead opted to just test TLS with this endpoint rather than HTTPS.

Testing:

The rust network integration test should now succeed in CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@goatgoose
Copy link
Contributor Author

resolved by #4907

@goatgoose goatgoose closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant