feat: add alert mappings for certificate errors #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
cert-alerts
branch
from
788761d
to
91d1610
Compare
camshaft
force-pushed
the
cert-alerts
branch
from
91d1610
to
104566f
Compare
goatgoose
approved these changes
Nov 20, 2024
Co-authored-by: Sam Clark <[email protected]>
lrstewart
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds more alert mappings, this time for certificate issues. This can provide a lot better insight into why the handshake is failing.
Call-outs:
One thing to note, as is still the case from #3171, this does not return alerts on the wire. It's only for the local TLS stack.
Testing:
I added
EXPECT_FAILURE_WITH_ALERTin a couple of places to show the mappings coming through.Long term, it would be nice to have some kind of snapshot tests for these mappings so we can be more exhaustive on the checks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.