test: pin optional client auth test to a TLS 1.2 policy #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
commented
Nov 19, 2024
Comment on lines
-38
to
+45
| EXPECT_SUCCESS(s2n_disable_tls13_in_test()); | ||
|
|
||
| EXPECT_NOT_NULL(cert_chain_pem = malloc(S2N_MAX_TEST_PEM_SIZE)); | ||
| EXPECT_NOT_NULL(private_key_pem = malloc(S2N_MAX_TEST_PEM_SIZE)); | ||
| EXPECT_NOT_NULL(dhparams_pem = malloc(S2N_MAX_TEST_PEM_SIZE)); | ||
|
|
||
| /* Setup baseline server config and certs. */ | ||
| EXPECT_NOT_NULL(server_config = s2n_config_new()); | ||
| EXPECT_SUCCESS(s2n_config_set_cipher_preferences(server_config, "20240501")); |
There was a problem hiding this comment.
This is a safe change because by calling s2n_disable_tls13_in_test() these tests assume a TLS1.2 policy today.
10 tasks
lrstewart
approved these changes
Nov 20, 2024
goatgoose
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4765
Description of changes:
Pin tests in
s2n_optional_client_auth_testto a TLS 1.2 security policy.Callout:
Why do we need this change?
These tests iterate thru all ciphers in the security policy and attempt a handshake. Currently all ciphers in the security policy are able to negotiate TLS1.2. When we introduce TLS 1.3 support to the default policy (by adding TLS1.3 ciphers),
s2n_disable_tls13_in_test()will work by setting thes2n_highest_protocol_versionto TLS1.2 to prevent negotiating TLS1.3.However, TLS1.3 only ciphers are not able to negotiate TLS1.2, causing the tests to fail.
Testing:
Existing tests should continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.