ci(refactor): remove Valgrind checks from omnibus and generalBatch #4913
+53
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A separate Valgrind test has been fully integrated into the github CI and the release CI. Therefore, Valgrind in generalBatch and Omnibus should be removed.
delete Valgrind sections.
dougch
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Our CIs for github and release runs Valgrind in
generalBatch/OmnibusandValgrind Codebuild job. Since a separate Valgrind test has been fully integrated into the github CI and the release CI, Valgrind in generalBatch and Omnibus should be removed.Description of changes:
buildspec_omnibus.ymlandbuildspec_generalbatch.yml.Makefiles ands2n_codebuild.sh.Call-outs:
s2nOmnibusjob's inline buildspec is out of date frombuildspec_omnibus.yml. I synced the inline buildspec fors2nOmnibustobuildspec_omnibus.tmlto make them consistent.s2nOmnibusjob takes in line buildspec. I need to manually copy and pastebuildspec_omnibus.ymlto the Codebuild job after this PR is merged.Testing:
Test by CI.
Test for this refactored
buildspec_omnibus.ymlcan be found in this codebuild job.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.