Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: kTLS specific nix devShell #4886

Closed
wants to merge 15 commits into from
Closed

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Nov 12, 2024

Resolved issues:

n/a

Description of changes:

We're running our kTLS tests under qemu without acceleration, which take over an hour. This change creates a minimal nix devShell with no python, corretto, aws-lc, etc.

High level timing currently:

  1. nix devshell - 15 min
  2. build - 30 min
  3. test - 15 min

(current PR) Running all unit tests with this minimal devShell takes 49 minutes. This effectively eliminates the devshell timing from above.

Call-outs:

Other options:

  • CodeBuilds recent announcement is likely a better long term fix, we'll merge this as-is.
  • Running only unit ktls drops the runtime to 38 minutes.
  • rm a bunch of unit tests; build time is the long pole, so the fewer tests we build, the faster it is.
  • run a full test run on a schedule and just do the minimum for the PR workflow.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? locally; Codebuild

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Nov 12, 2024
@dougch dougch marked this pull request as ready for review November 12, 2024 18:36
codebuild/spec/buildspec_ktls.yml Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@dougch dougch marked this pull request as draft November 14, 2024 00:19
@dougch dougch marked this pull request as ready for review November 14, 2024 18:55
@dougch dougch enabled auto-merge (squash) November 14, 2024 18:55
@dougch dougch marked this pull request as draft November 18, 2024 22:55
auto-merge was automatically disabled November 18, 2024 22:55

Pull request was converted to draft

@dougch
Copy link
Contributor Author

dougch commented Nov 18, 2024

drafting this; the new CodeBuild Ec2 instance runner is way faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants