-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added a test where there is no ips #7549
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
this pr is adding a test before merging #7310, which fixes issues #5234 , #2921 |
thank u for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
this looks good to me,thanks!
@jigisha620 Hey, when you get a chance, it would mean a lot if you could take a quick look at this PR. I know you’re busy, but your feedback would be really valuable to us (me and @Vacant2333) |
@Summonair This change should really be in PR: #7310, since we will need to wait until that PR is merged before pushing this change. Also seems like we have failures not related to Karpenter behavior in the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bring these changes to #7310.
hey, i fixed the ci errors, how can i merge to his pr? |
@Summonair Thanks for you help! |
Closing this in favor of #7623 so that we can track the discussions in a single thread. |
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.