Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added a test where there is no ips #7549

Closed
wants to merge 4 commits into from

Conversation

Summonair
Copy link

@Summonair Summonair commented Dec 21, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Summonair Summonair requested a review from a team as a code owner December 21, 2024 16:34
@Summonair Summonair requested a review from jigisha620 December 21, 2024 16:35
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c5a1136
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6791650a0c99c2000866fbbf

@Summonair
Copy link
Author

this pr is adding a test before merging #7310, which fixes issues #5234 , #2921
@rschalo i've added the test you asked in #7310 (comment)

@Vacant2333
Copy link
Contributor

thank u for this!
/assign

Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
this looks good to me,thanks!

@Summonair
Copy link
Author

@jigisha620 Hey, when you get a chance, it would mean a lot if you could take a quick look at this PR. I know you’re busy, but your feedback would be really valuable to us (me and @Vacant2333)

@Vacant2333
Copy link
Contributor

@rschalo hi, can u help us to review this pr? its really important for the issue #5234

@engedaam
Copy link
Contributor

@Summonair This change should really be in PR: #7310, since we will need to wait until that PR is merged before pushing this change. Also seems like we have failures not related to Karpenter behavior in the test

@Vacant2333
Copy link
Contributor

@engedaam Can we merge #7310 first and add ut later?

Copy link
Contributor

@saurav-agarwalla saurav-agarwalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring these changes to #7310.

@saurav-agarwalla saurav-agarwalla self-assigned this Jan 22, 2025
@Summonair
Copy link
Author

Please bring these changes to #7310.

hey, i fixed the ci errors, how can i merge to his pr?
@Vacant2333 can u add me push perms on your fork so i can create a branch on yours?

@Vacant2333
Copy link
Contributor

@Summonair Thanks for you help!
I have invite u to my fork repo, u should be able to push and create a branch on my fork
ref: https://github.com/Vacant2333/karpenter-provider-aws

@saurav-agarwalla
Copy link
Contributor

Closing this in favor of #7623 so that we can track the discussions in a single thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants