release: v0.20.4 (#974)

Added code to up-cast from `dict` to the relevant struct type in the generated python code whenever the value type is some unambiguous struct. Whenever a UNION of types is involved, the user must construct the struct type themselves, as the runtime would then have no way to choose which type should be used on it's own without additional information.
aws · Nov 12, 2019 · 96d89e1 · 96d89e1
1 parent 26aa77c
commit 96d89e1
Show file tree

Hide file tree

Showing 113 changed files with 1,360 additions and 207 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+
+### Bug Fixes
+
+* **python:** correctly handle nested structs-as-dict ([#973](https://github.com/aws/jsii/issues/973)) ([9fd2499](https://github.com/aws/jsii/commit/9fd2499388745cf63d194a47bf247e5e24f4a7db))
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 

diff --git a/lerna.json b/lerna.json
@@ -10,5 +10,5 @@
       "rejectCycles": true
     }
   },
-  "version": "0.20.3"
+  "version": "0.20.4"
 }
diff --git a/packages/codemaker/CHANGELOG.md b/packages/codemaker/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+**Note:** Version bump only for package codemaker
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package codemaker

diff --git a/packages/codemaker/package.json b/packages/codemaker/package.json
@@ -1,6 +1,6 @@
 {
   "name": "codemaker",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "description": "A tiny utility for generating source code",
   "license": "Apache-2.0",
   "author": {

diff --git a/packages/jsii-build-tools/CHANGELOG.md b/packages/jsii-build-tools/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+**Note:** Version bump only for package jsii-build-tools
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package jsii-build-tools

diff --git a/packages/jsii-build-tools/package.json b/packages/jsii-build-tools/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jsii-build-tools",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "private": true,
   "description": "Internal repository-level tools",
   "license": "Apache-2.0",

diff --git a/packages/jsii-calc-base-of-base/CHANGELOG.md b/packages/jsii-calc-base-of-base/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+**Note:** Version bump only for package @scope/jsii-calc-base-of-base
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package @scope/jsii-calc-base-of-base

diff --git a/packages/jsii-calc-base-of-base/package.json b/packages/jsii-calc-base-of-base/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@scope/jsii-calc-base-of-base",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "private": true,
   "description": "An example transitive dependency for jsii-calc.",
   "license": "Apache-2.0",
@@ -29,8 +29,8 @@
     "test:update": "npm run build && UPDATE_DIFF=1 npm run test"
   },
   "devDependencies": {
-    "jsii": "^0.20.3",
-    "jsii-build-tools": "^0.20.3"
+    "jsii": "^0.20.4",
+    "jsii-build-tools": "^0.20.4"
   },
   "jsii": {
     "outdir": "dist",

diff --git a/packages/jsii-calc-base-of-base/test/assembly.jsii b/packages/jsii-calc-base-of-base/test/assembly.jsii
@@ -9,7 +9,7 @@
   },
   "description": "An example transitive dependency for jsii-calc.",
   "homepage": "https://github.com/aws/jsii",
-  "jsiiVersion": "0.20.3",
+  "jsiiVersion": "0.20.4",
   "license": "Apache-2.0",
   "name": "@scope/jsii-calc-base-of-base",
   "repository": {
@@ -110,6 +110,6 @@
       ]
     }
   },
-  "version": "0.20.3",
-  "fingerprint": "bEQA39uj2RUus5ZFJHS6u+4dObsdCz+6nz1OCgC8gEA="
+  "version": "0.20.4",
+  "fingerprint": "CTFOBPl1h1P7OanPGuUCZj/kGnWefYnRI7+Kks7Oux8="
 }
diff --git a/packages/jsii-calc-base/CHANGELOG.md b/packages/jsii-calc-base/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+**Note:** Version bump only for package @scope/jsii-calc-base
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package @scope/jsii-calc-base

diff --git a/packages/jsii-calc-base/package.json b/packages/jsii-calc-base/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@scope/jsii-calc-base",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "private": true,
   "description": "An example direct dependency for jsii-calc.",
   "license": "Apache-2.0",
@@ -29,14 +29,14 @@
     "test:update": "npm run build && UPDATE_DIFF=1 npm run test"
   },
   "dependencies": {
-    "@scope/jsii-calc-base-of-base": "^0.20.3"
+    "@scope/jsii-calc-base-of-base": "^0.20.4"
   },
   "peerDependencies": {
-    "@scope/jsii-calc-base-of-base": "^0.20.3"
+    "@scope/jsii-calc-base-of-base": "^0.20.4"
   },
   "devDependencies": {
-    "jsii": "^0.20.3",
-    "jsii-build-tools": "^0.20.3"
+    "jsii": "^0.20.4",
+    "jsii-build-tools": "^0.20.4"
   },
   "jsii": {
     "outdir": "dist",

diff --git a/packages/jsii-calc-base/test/assembly.jsii b/packages/jsii-calc-base/test/assembly.jsii
@@ -29,7 +29,7 @@
           "module": "scope.jsii_calc_base_of_base"
         }
       },
-      "version": "0.20.3"
+      "version": "0.20.4"
     }
   },
   "dependencyClosure": {
@@ -54,12 +54,12 @@
           "module": "scope.jsii_calc_base_of_base"
         }
       },
-      "version": "0.20.3"
+      "version": "0.20.4"
     }
   },
   "description": "An example direct dependency for jsii-calc.",
   "homepage": "https://github.com/aws/jsii",
-  "jsiiVersion": "0.20.3",
+  "jsiiVersion": "0.20.4",
   "license": "Apache-2.0",
   "name": "@scope/jsii-calc-base",
   "repository": {
@@ -173,6 +173,6 @@
       "name": "IBaseInterface"
     }
   },
-  "version": "0.20.3",
-  "fingerprint": "0IR7KelwYefWdNKrUGCmpipMIXqmySYWQo3Ie0GLs0E="
+  "version": "0.20.4",
+  "fingerprint": "QA/Uez7P6b9LKt4LeSdtpljkoj/RINtXWde4MjtExkk="
 }
diff --git a/packages/jsii-calc-lib/CHANGELOG.md b/packages/jsii-calc-lib/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+**Note:** Version bump only for package @scope/jsii-calc-lib
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package @scope/jsii-calc-lib

diff --git a/packages/jsii-calc-lib/package.json b/packages/jsii-calc-lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@scope/jsii-calc-lib",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "private": true,
   "description": "A simple calcuator library built on JSII.",
   "deprecated": "Really just deprecated for shows...",
@@ -31,14 +31,14 @@
     "test:update": "npm run build && UPDATE_DIFF=1 npm run test"
   },
   "dependencies": {
-    "@scope/jsii-calc-base": "^0.20.3"
+    "@scope/jsii-calc-base": "^0.20.4"
   },
   "peerDependencies": {
-    "@scope/jsii-calc-base": "^0.20.3"
+    "@scope/jsii-calc-base": "^0.20.4"
   },
   "devDependencies": {
-    "jsii": "^0.20.3",
-    "jsii-build-tools": "^0.20.3"
+    "jsii": "^0.20.4",
+    "jsii-build-tools": "^0.20.4"
   },
   "jsii": {
     "outdir": "dist",

diff --git a/packages/jsii-calc-lib/test/assembly.jsii b/packages/jsii-calc-lib/test/assembly.jsii
@@ -29,7 +29,7 @@
           "module": "scope.jsii_calc_base"
         }
       },
-      "version": "0.20.3"
+      "version": "0.20.4"
     }
   },
   "dependencyClosure": {
@@ -54,7 +54,7 @@
           "module": "scope.jsii_calc_base"
         }
       },
-      "version": "0.20.3"
+      "version": "0.20.4"
     },
     "@scope/jsii-calc-base-of-base": {
       "targets": {
@@ -77,7 +77,7 @@
           "module": "scope.jsii_calc_base_of_base"
         }
       },
-      "version": "0.20.3"
+      "version": "0.20.4"
     }
   },
   "description": "A simple calcuator library built on JSII.",
@@ -86,7 +86,7 @@
     "stability": "deprecated"
   },
   "homepage": "https://github.com/aws/jsii",
-  "jsiiVersion": "0.20.3",
+  "jsiiVersion": "0.20.4",
   "license": "Apache-2.0",
   "name": "@scope/jsii-calc-lib",
   "repository": {
@@ -538,6 +538,6 @@
       ]
     }
   },
-  "version": "0.20.3",
-  "fingerprint": "ui/3zA+Ppo35hXyXMm3f+YynqNBsOq2i44VaPZh0/hY="
+  "version": "0.20.4",
+  "fingerprint": "cgTc9JCOUBd+KkYayX1pTHgJDYQiMTSS/tdj48cUUn0="
 }
diff --git a/packages/jsii-calc/CHANGELOG.md b/packages/jsii-calc/CHANGELOG.md
@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.20.4](https://github.com/aws/jsii/compare/v0.20.3...v0.20.4) (2019-11-12)
+
+
+### Bug Fixes
+
+* **python:** correctly handle nested structs-as-dict ([#973](https://github.com/aws/jsii/issues/973)) ([9fd2499](https://github.com/aws/jsii/commit/9fd2499388745cf63d194a47bf247e5e24f4a7db))
+
+
+
+
+
 ## [0.20.3](https://github.com/aws/jsii/compare/v0.20.2...v0.20.3) (2019-11-11)
 
 **Note:** Version bump only for package jsii-calc

diff --git a/packages/jsii-calc/lib/compliance.ts b/packages/jsii-calc/lib/compliance.ts
@@ -2175,3 +2175,36 @@ class PrivateBell implements IBell {
         this.rung = true;
     }
 }
+
+/**
+ * This is here to check that we can pass a nested struct into a kwargs by specifying it as an
+ * in-line dictionary. This is cheating with the declared types, but Python people don't play by
+ * the rules much apparently.
+ */
+export interface RootStruct {
+    /**
+     * May not be empty.
+     */
+    readonly stringProp: string;
+    readonly nestedStruct?: NestedStruct;
+}
+export interface NestedStruct {
+    /**
+     * When provided, must be > 0.
+     */
+    readonly numberProp: number;
+}
+export class RootStructValidator {
+    public static validate(struct: RootStruct): void {
+        if (!struct.stringProp) {
+            throw new Error('Missing required field: stringProp');
+        }
+        if (struct.nestedStruct) {
+            if (struct.nestedStruct.numberProp <= 0) {
+                throw new Error('numberProp must be > 0');
+            }
+        }
+    }
+
+    private constructor() { }
+}
diff --git a/packages/jsii-calc/package.json b/packages/jsii-calc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jsii-calc",
-  "version": "0.20.3",
+  "version": "0.20.4",
   "private": true,
   "description": "A simple calcuator built on JSII.",
   "stability": "experimental",
@@ -31,19 +31,19 @@
     "test:update": "npm run build && UPDATE_DIFF=1 npm run test"
   },
   "dependencies": {
-    "@scope/jsii-calc-base": "^0.20.3",
-    "@scope/jsii-calc-base-of-base": "^0.20.3",
-    "@scope/jsii-calc-lib": "^0.20.3",
+    "@scope/jsii-calc-base": "^0.20.4",
+    "@scope/jsii-calc-base-of-base": "^0.20.4",
+    "@scope/jsii-calc-lib": "^0.20.4",
     "jsii-calc-bundled": "file:../@fixtures/jsii-calc-bundled"
   },
   "peerDependencies": {
-    "@scope/jsii-calc-base": "^0.20.3",
-    "@scope/jsii-calc-base-of-base": "^0.20.3",
-    "@scope/jsii-calc-lib": "^0.20.3"
+    "@scope/jsii-calc-base": "^0.20.4",
+    "@scope/jsii-calc-base-of-base": "^0.20.4",
+    "@scope/jsii-calc-lib": "^0.20.4"
   },
   "devDependencies": {
-    "jsii": "^0.20.3",
-    "jsii-build-tools": "^0.20.3"
+    "jsii": "^0.20.4",
+    "jsii-build-tools": "^0.20.4"
   },
   "jsii": {
     "outdir": "dist",