Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.23 #9146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Jan 8, 2025

Bump Go version to v1.23 and controller-gen to v0.16.5 in eks-anywhere codebase.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from abhay-krishna. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (79b3a53) to head (74da858).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9146      +/-   ##
==========================================
- Coverage   72.37%   69.39%   -2.98%     
==========================================
  Files         585      668      +83     
  Lines       45713    48702    +2989     
==========================================
+ Hits        33085    33797     +712     
- Misses      10890    13141    +2251     
- Partials     1738     1764      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@abhay-krishna abhay-krishna force-pushed the go-1.23 branch 2 times, most recently from e185e58 to 5035a0a Compare January 8, 2025 23:31
@abhay-krishna abhay-krishna changed the title Bump Go version to 1.23 Bump Go version to 1.23, fix Dependabot vulnerabilities Jan 8, 2025
@abhay-krishna abhay-krishna force-pushed the go-1.23 branch 5 times, most recently from 1095ea3 to d02b06d Compare January 9, 2025 22:22
@abhay-krishna abhay-krishna reopened this Jan 10, 2025
@abhay-krishna abhay-krishna changed the title Bump Go version to 1.23, fix Dependabot vulnerabilities Bump Go version to 1.23 Jan 10, 2025
@abhay-krishna abhay-krishna force-pushed the go-1.23 branch 3 times, most recently from e7a694e to 909846a Compare January 14, 2025 21:58
@abhay-krishna
Copy link
Member Author

/retest

1 similar comment
@abhay-krishna
Copy link
Member Author

/retest

@abhay-krishna abhay-krishna force-pushed the go-1.23 branch 3 times, most recently from 1cad7f9 to 4d5020b Compare January 15, 2025 18:58
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Jan 16, 2025

@abhay-krishna: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-generate-files-presubmit 74da858 link true /test eks-anywhere-generate-files-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants